-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kdp to v0.15.0-beta.1 #1038
Upgrade kdp to v0.15.0-beta.1 #1038
Conversation
fbdae27
to
ca0afaf
Compare
a34cb8b
to
1d8a442
Compare
LGTM except for the resources.claims change. I'm guessing this was introduced upstream in k8s and we're reusing the k8s type here. I'm also guessing we would have problems if someone actually set this new value (?). Maybe we want to define our own version of resources so we don't pick up the new "claims" field? |
4b5ef7e
to
4435362
Compare
Hi @justinsb , thank you for reviewing!
Yes,
I'm not familiar with this feature enough to determine if it'll be problematic or not off the top of my head, so agreed we should play it safe. I made a local copy of this type without the |
Thanks @maqiuyujoyce - lgtm with the embedding of the resource type! /approve Looks like it'll need a rebase on go.mod though |
Next steps: 1. ensure `make test` pass 2. ensure `make generate-go-client` doesn't generate diffs
6cb716e
to
5906123
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abdff8c
into
GoogleCloudPlatform:master
Change description
Fixes b/309175495
ResourceRequirements
type to avoid adding new fields into ControllerResource and NamespacedControllerResource.Watches()
function withWatchesRawSource()
function in controllers. Updated the parameter forWatches()
function.singleResourceClient
anderrorClient
to match the latest interface of the controller-runtime client.GoHeaderFilePath
from deepcopy-gen and client-gen. The line of code turns out to be unnecessary.Tests you have done
make ready-pr
to ensure this PR is ready for review.make test
passed.